dlmarion commented on code in PR #6121:
URL: https://github.com/apache/accumulo/pull/6121#discussion_r2790626824
##########
shell/src/main/java/org/apache/accumulo/shell/Shell.java:
##########
@@ -510,23 +481,20 @@ public String keyword() {
@Override
public UsageGroup usageGroup() {
- return UsageGroup.CORE;
+ return UsageGroups.CLIENT;
}
@Override
public String description() {
return "Runs Accumulo shell";
}
- @SuppressFBWarnings(value = "DM_EXIT", justification = "System.exit() from a
main class is okay")
@Override
- public void execute(final String[] args) throws IOException {
+ public void execute(JCommander cl, ShellOptions options) throws Exception {
try {
- if (!config(args)) {
- System.exit(getExitCode());
+ if (config(cl, options)) {
+ start();
}
-
- System.exit(start());
} finally {
shutdown();
}
Review Comment:
One thing to note here is that the call to System.exit is removed from the
Shell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
