keith-turner commented on code in PR #6146:
URL: https://github.com/apache/accumulo/pull/6146#discussion_r2842807710
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServer.java:
##########
@@ -477,6 +488,79 @@ public void run() {
}
}
+ // Visible for testing
+ protected boolean isAllowed(TableId tid) {
+ boolean result = allowedTables.containsKey(tid);
Review Comment:
Need to differentiate between not existing in the map and a table id is
known to not be allowed. Seems like if a table is not allowed it will
constantly regenrate the entire cache for all tables. Could make the value in
the map a boolean, then can know all three states of allowed, not allowed,
unknown.
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -561,6 +561,13 @@ public enum Property {
"The amount of time a scan reference is unused before its deleted from
metadata table.",
"2.1.0"),
@Experimental
+ SSERV_SCAN_ALLOWED_TABLES("sserver.scan.allowed.tables.group.", null,
PropertyType.PREFIX,
+ "A regular expression that determines which tables are allowed to be
scanned for"
+ + " servers in the specified group. The property name should end
with the scan server"
Review Comment:
In 4.0, with the changes in #5749 would not need to group name in the
property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
