DomGarguilo commented on PR #6165:
URL: https://github.com/apache/accumulo/pull/6165#issuecomment-3992313770

   > I like the direction this is going, but I think we can pay the computation 
cost once instead of on page refresh for every user of the Monitor. Also, since 
we are working on optimization, there is an option to return the JSON from the 
server in [CBOR](https://cbor.io/) encoding. I have done this in another 
project, 
[here](https://github.com/NationalSecurityAgency/qonduit/blob/master/server/src/main/java/qonduit/util/JsonUtil.java#L19),
 and Jackson already supports it. We would need to decode the response in the 
UI javascript, but I'm sure that's already supported.
   
   I think CBOR encoding would reduce the payload size for each bundle of 
information sent to the monitor frontend but I'm not sure the extra complexity 
is worth it here. The payloads are already pretty small. I do think your other 
commend about precomputing/caching this new DTO in some capacity would be worth 
it. I think I will work on adding that to this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to