ddanielr commented on PR #6166:
URL: https://github.com/apache/accumulo/pull/6166#issuecomment-3998847492

   > > The new ServiceLock code was calling recursiveDelete directly with the 
top-level path. So it was removing all the gc locks
   > 
   > Ok, so it seems after these changes that the ServiceLock method and 
ZooZap.removeSingletonLock now behave in a very similar way, except they seem 
to report/log differently. Noticed that could lead to inconsistent 
logging/printing.
   
   Yes I think we can iterate a bit further on this and remove the 
`removeSingletonLock` method from ZooZap. 
   I was trying to get all of the lock removals moved into ServiceLock so the 
lock creation and deletion is centralized.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to