dlmarion commented on code in PR #6181:
URL: https://github.com/apache/accumulo/pull/6181#discussion_r2891909734
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -925,6 +926,22 @@ private void
checkForHeldServer(SortedMap<TServerInstance,TabletServerStatus> ts
return info;
}
+ private void setupMetrics() {
+ MetricsInfo metricsInfo = getContext().getMetricsInfo();
+ metricsInfo.addMetricsProducers(balanceManager.getMetrics());
+ watchers.forEach(watcher ->
metricsInfo.addMetricsProducers(watcher.getMetrics()));
Review Comment:
Maybe want to pass the Watchers into this method instead of referencing it
directly. Reason being that if the call to this method was moved in the future,
then it might be more apparent that watcher metrics will not longer be emitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
