keith-turner commented on code in PR #6191:
URL: https://github.com/apache/accumulo/pull/6191#discussion_r2892919234
##########
assemble/conf/log4j2-service.properties:
##########
@@ -32,7 +32,7 @@ appender.console.type = Console
appender.console.name = STDERR
appender.console.target = SYSTEM_ERR
appender.console.layout.type = PatternLayout
-appender.console.layout.pattern = %d{ISO8601} [%-8c{2}] %-5p: %m%n
+appender.console.layout.pattern = %d{ISO8601} [%T;%t] [%-8c{2}] %-5p: %m%n
Review Comment:
Some code sets thread names to make jstacks more informative like
[here](https://github.com/apache/accumulo/blob/087bf8aee8af8660af7d383d16b262be1cf6c5cc/server/tserver/src/main/java/org/apache/accumulo/tserver/scan/NextBatchTask.java#L68).
Including the thread name on each log message could be a lot for those cases.
Have you run ITs w/ these configs? Wonder what that looks like.
##########
core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java:
##########
@@ -131,26 +135,27 @@ public String getInstanceID() {
return instanceId;
}
+ @Deprecated
Review Comment:
Why did this annotation need to be added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
