ctubbsii commented on code in PR #102:
URL: https://github.com/apache/accumulo-access/pull/102#discussion_r2913730569


##########
modules/core/src/main/java/org/apache/accumulo/access/AccessExpression.java:
##########
@@ -50,11 +53,7 @@ protected AccessExpression() {}
 
   @Override
   public boolean equals(Object o) {
-    if (o instanceof AccessExpression) {
-      return ((AccessExpression) o).getExpression().equals(getExpression());
-    }
-
-    return false;
+    return o instanceof AccessExpression a && Objects.equals(getExpression(), 
a.getExpression());

Review Comment:
   Added `this == o` suggestion in ce911c308c1f3c23eee5436476b527b4cb5db040 (I 
missed it before merging)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to