ctubbsii commented on code in PR #6354:
URL: https://github.com/apache/accumulo/pull/6354#discussion_r3171271381
##########
core/src/main/java/org/apache/accumulo/core/fate/FateKey.java:
##########
@@ -200,14 +195,6 @@ private static Optional<ExternalCompactionId>
deserializeCompactionId(FateKeyTyp
};
}
- private static Optional<TServerInstance> deserializeTserverId(FateKeyType
type,
- DataInputBuffer buffer) throws IOException {
- return switch (type) {
- case SPLIT, MERGE, COMPACTION_COMMIT -> Optional.empty();
- case TSERVER_SHUTDOWN -> Optional.of(new
TServerInstance(buffer.readUTF()));
- };
- }
-
Review Comment:
@keith-turner I think the tServerInstance field became unused after recent
distributed Fate changes, but there remains a FateKey constructor that accepts
a TServerInstance that is serialized, but then it is never deserialized. I
think there's probably some unnecessary stuff going on here, even after my
changes, because it doesn't seem useful to have a code path that serializes a
TServerInstance when it will never be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
