dlmarion commented on code in PR #6356:
URL: https://github.com/apache/accumulo/pull/6356#discussion_r3174589853
##########
server/monitor/src/main/java/org/apache/accumulo/monitor/next/SystemInformation.java:
##########
@@ -703,13 +700,50 @@ public void addConfiguredCompactionGroups(Set<String>
groups) {
configuredCompactionResourceGroups.addAll(groups);
}
- public void finish() {
- // Update the deployment not-responded numbers based
- // on metric fetch failures for this refresh.
- metricProblemHosts.forEach(serverId -> {
- deployment.computeIfAbsent(serverId.getResourceGroup(), g -> new
ConcurrentHashMap<>())
- .computeIfAbsent(serverId.getType(), t -> new
ProcessSummary()).addNotResponded(serverId);
+ private void computeMessages() {
+
+ if (managers.isEmpty()) {
+ addMessage(Critical, Resource, "No Managers are running");
+ }
+
+ if (gc.get() == null) {
+ addMessage(Critical, Resource, "Garbage Collector is not running");
+ }
+
+ if (problemHosts.size() > 0) {
+ addMessage(Info, Resource, "Monitor has not recevied a response from " +
problemHosts.size()
+ + " servers in the last 10 minutes");
+ }
+
+ if (metricProblemHosts.size() > 0) {
+ addMessage(Info, Resource,
+ "Unable to gather information from " + metricProblemHosts.size() + "
servers");
+ }
+
+ for (ResourceGroupId rg : ctx.resourceGroupOperations().list()) {
+ if (rg == ResourceGroupId.DEFAULT) {
+ continue;
+ }
+ if (!compactors.containsKey(rg.canonical()) &&
!sservers.containsKey(rg.canonical())
+ && !tservers.containsKey(rg.canonical())) {
+ addMessage(Info, Configuration, "Resource Group " + rg
+ + " exists, but no resources assigned. Consider removing the
resource group");
Review Comment:
Created #6357 for a related issue. Could suggest how to do it in this
message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
