ctubbsii commented on code in PR #6465:
URL: https://github.com/apache/accumulo/pull/6465#discussion_r3626582003
##########
server/base/src/main/java/org/apache/accumulo/server/util/PropUtil.java:
##########
@@ -21,16 +21,26 @@
import java.io.IOException;
import java.util.Collection;
import java.util.Map;
+import java.util.TreeMap;
+import java.util.TreeSet;
import org.apache.accumulo.core.classloader.ClassLoaderUtil;
import org.apache.accumulo.core.conf.Property;
import org.apache.accumulo.server.ServerContext;
+import org.apache.accumulo.server.conf.store.NamespacePropKey;
import org.apache.accumulo.server.conf.store.PropStoreKey;
+import org.apache.accumulo.server.conf.store.SystemPropKey;
+import org.apache.accumulo.server.conf.store.TablePropKey;
import org.apache.hadoop.hdfs.DistributedFileSystem;
import org.apache.hadoop.hdfs.protocol.ErasureCodingPolicyInfo;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public final class PropUtil {
+ private static final Logger CONFIG_LOG =
+ LoggerFactory.getLogger("org.apache.accumulo.configuration");
Review Comment:
@DomGarguilo We have precedent for having certain loggers that are not based
on a class to be named uppercase. See LoggingMeterRegistryFactory's
"org.apache.accumulo.METRICS". Perhaps this should be changed to
"org.apache.accumulo.CONFIG" to follow that same convention?
```suggestion
LoggerFactory.getLogger("org.apache.accumulo.CONFIG");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
