[
https://issues.apache.org/jira/browse/IVYDE-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781133#action_12781133
]
Nicolas Lalevée commented on IVYDE-208:
---------------------------------------
I finally took time to review the patch: great job Jon ! I don't know at all
the Zest API but it looks good :)
I think there is a legal issue here though. All patches have been properly
granted for inclusion in ASF works under the ASL. But it includes work from
Ivica Loncar in his [comment of 03/Oct/09 10:07
PM|https://issues.apache.org/jira/browse/IVYDE-208?focusedCommentId=12761963&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12761963]
which hasn't any license.
So Ivica could you please attach a file with the code you posted and grant
license to ASF for inclusion in ASF works ?
A little question: why the package containing ILabelDecoratorAlgorithm and its
implementation is named "label" ?
And a nitpicking remark: at the beginning of using it I was searching of how to
link the view with a ivy.xml. I think it would help to have a "Show in Resolve
Vizualizer" in the context menu of the project. And also maybe change the icon
in view: the current icon (a magnifying glass) made me think a search, rather
than "open"; probably an icon of an opened folder would better fit.
Then about the dependency on Zest, should we make it required ? I didn't found
the requirement of Zest itself. IvyDE today is expected to support Eclipse 3.2,
but this could change if necessary, we may want to ask IvyDE users too. I don't
know if it is even possible to have an optional view depending of some
dependency, maybe by making it a separate plugin...
> Ivy Resolve Visualizer
> ----------------------
>
> Key: IVYDE-208
> URL: https://issues.apache.org/jira/browse/IVYDE-208
> Project: IvyDE
> Issue Type: New Feature
> Reporter: Jon Schneider
> Attachments: evicted.gif, focus.gif, ivy.xml, ivyde-208.patch,
> ivyde-208.patch, ivyde-208.patch, ivyde-208.patch, ivyde-208.patch,
> screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, screenshot-4.jpg,
> screenshot-5.jpg, screenshot-6.jpg
>
>
> I am kind of excited about this one. I would like to be able to see the
> resolve report depicted graphically, showing me clearly how particular
> dependencies wound up on the classpath, what nodes got evicted, what
> dependencies a particular transitive dependency has, etc etc. Ivy can
> sometimes fall into the category of "automagically" doing so much for us on
> the classpath, that developers can take it for granted. Especially when a
> version conflict arises out of a resolution (by which two different revisions
> are resolved that aren't under the same eviction context), I see developers
> getting very confused. I hope this visualization will help them understand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
