[ 
https://issues.apache.org/jira/browse/IVY-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255373#comment-13255373
 ] 

Thomas Kurpick commented on IVY-1343:
-------------------------------------

Patch for AbstractOSGiResolver

Index: src/java/org/apache/ivy/osgi/repo/AbstractOSGiResolver.java
===================================================================
--- src/java/org/apache/ivy/osgi/repo/AbstractOSGiResolver.java (revision 
1326555)
+++ src/java/org/apache/ivy/osgi/repo/AbstractOSGiResolver.java (working copy)
@@ -294,7 +294,10 @@
 
     public ResolvedResource findArtifactRef(Artifact artifact, Date date) {
         URL url = artifact.getUrl();
-        Message.verbose("\tusing url for " + artifact + ": " + url);
+        if (url == null) {
+            return null;
+        }
+        Message.verbose("\tusing url for " + artifact + ": " + 
url.toExternalForm());
         logArtifactAttempt(artifact, url.toExternalForm());
         Resource resource = new URLResource(url);
         return new ResolvedResource(resource, 
artifact.getModuleRevisionId().getRevision());

                
> NullPointerExeption in AbstractOSGiResolver
> -------------------------------------------
>
>                 Key: IVY-1343
>                 URL: https://issues.apache.org/jira/browse/IVY-1343
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.3.0-RC1, 2.3.0, trunk
>         Environment: Ubuntu 2.6.32-25-generic-pae,
> java version "1.6.0_26"
> Java(TM) SE Runtime Environment (build 1.6.0_26-b03)
> Java HotSpot(TM) Server VM (build 20.1-b02, mixed mode)
> Apache Ant version 1.8.0 compiled on April 9 2010
>            Reporter: Thomas Kurpick
>            Priority: Critical
>              Labels: patch
>         Attachments: UpdateSiteAndIbiblioResolverTest.java, patch.txt
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> A NullPointerException is thrown, if I try to resolve a dependency after I 
> cleared the cache.
> Steps to reproduce:
> 1. create a ivysettings.xml with a chain including a ibiblio and an 
> updatesite as resolver.
> 2. create a dependency to a artifact that can be found with the ibiblio 
> resolver.
> 3. call ivy retrieve
> actual result:
>  - no dependency is resolved and retrieved and a NullPointerException is 
> thrown
> expected result:
>  - dependency is resolved and retrieved from ibiblio
> See also the attached patch and test case.
> ---
> problem occurred while resolving dependency: org.mod4j.com.ibm#icu;4.0.1 
> {compile=[*, !sources, !javadoc]} with p2-repos: 
> java.lang.NullPointerException
>       at 
> org.apache.ivy.osgi.repo.AbstractOSGiResolver.findIvyFileRef(AbstractOSGiResolver.java:132)
>       at 
> org.apache.ivy.plugins.resolver.BasicResolver.getDependency(BasicResolver.java:228)
>       at 
> org.apache.ivy.plugins.resolver.ChainResolver.getDependency(ChainResolver.java:104)
>       at org.apache.ivy.core.resolve.IvyNode.loadData(IvyNode.java:169)
>       at org.apache.ivy.core.resolve.VisitNode.loadData(VisitNode.java:292)
>       at 
> org.apache.ivy.core.resolve.ResolveEngine.fetchDependencies(ResolveEngine.java:695)
>       at 
> org.apache.ivy.core.resolve.ResolveEngine.doFetchDependencies(ResolveEngine.java:780)
>       at 
> org.apache.ivy.core.resolve.ResolveEngine.fetchDependencies(ResolveEngine.java:703)
>       at 
> org.apache.ivy.core.resolve.ResolveEngine.getDependencies(ResolveEngine.java:575)
>       at 
> org.apache.ivy.core.resolve.ResolveEngine.resolve(ResolveEngine.java:233)
>       at 
> org.apache.ivy.core.resolve.ResolveEngine.resolve(ResolveEngine.java:194)
>       at org.apache.ivy.Ivy.resolve(Ivy.java:503)
>       at org.apache.ivy.Main.run(Main.java:270)
>       at org.apache.ivy.Main.main(Main.java:179)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to