[
https://issues.apache.org/jira/browse/IVY-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949884#comment-16949884
]
Jaikiran Pai commented on IVY-1609:
-----------------------------------
Hello Greg,
You are right - it should only be logged when someone uses it. That message
isn't expected to be logged if no one is calling the setMakeSymlinksInMass
(directly or indirectly). So I had a look at the code and the only time this
method gets called is, if some did indeed use the `symlinkmass` option - either
by passing `symlinkmass` as a command line option to Main or setting the
symlinkmass option of retrieve task.
Are you certain that in the embedded case, the `symlinkmass` isn't being passed
to Main class or even retrieve task?
> Removal of WARN deprecation when not valid
> ------------------------------------------
>
> Key: IVY-1609
> URL: https://issues.apache.org/jira/browse/IVY-1609
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.0-rc1
> Reporter: Greg Perry
> Assignee: Jaikiran Pai
> Priority: Minor
> Labels: easyfix
>
> "WARN: symlinkmass option has been deprecated and will no longer be
> supported" gets fed back as a problem message, even when this option is not
> set.
> I noticed this when trying to get integration to work with embedding ivy.
> The program which utilizes ivy checks ResolveReport.getAllProblemMessages()
> after a resolve/retrieve is done.
> It assumes something did not go correctly.
> I don't think its appropriate to send this back in getAllProblemMessages when
> the symlinkmass is not set.
> This could be fixed simply by testing if symlinkmass is being set to true in
> the option
> RetrieveOptions.java line 184
> https://github.com/apache/ant-ivy/blob/master/src/java/org/apache/ivy/core/retrieve/RetrieveOptions.java#L183-L188
>
> @Deprecated
> public RetrieveOptions setMakeSymlinksInMass(boolean makeSymlinksInMass) {
> this.makeSymlinksInMass = makeSymlinksInMass;
> *if (makeSymlinksInMass) {*
> Message.warn("symlinkmass option has been deprecated and will no
> longer be supported");
> *}*
> return this;
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
