This is an automated email from the ASF dual-hosted git repository.
jaikiran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ant.git
The following commit(s) were added to refs/heads/master by this push:
new d2124835f remove unused simian tool
d2124835f is described below
commit d2124835f4cd9f0d0264c78ff67a3e2329fd0f39
Author: Jaikiran Pai <[email protected]>
AuthorDate: Wed Feb 21 19:57:27 2024 +0530
remove unused simian tool
---
check.xml | 52 +-----------------------------------
src/etc/checkstyle/checkstyle-config | 1 -
2 files changed, 1 insertion(+), 52 deletions(-)
diff --git a/check.xml b/check.xml
index fe3baccff..ca93c71a4 100644
--- a/check.xml
+++ b/check.xml
@@ -19,7 +19,7 @@
<description>
Check Ant codebase against certain code style guidelines using
- Checkstyle, Apache Rat, SpotBugs, OWASP Dependency Check, Simian
+ Checkstyle, Apache Rat, SpotBugs, OWASP Dependency Check
and Nu Html Checker (v.Nu).
Checkstyle uses an abstract syntax tree (AST) for doing checks
@@ -37,11 +37,6 @@
available at https://www.owasp.org/index.php/OWASP_Dependency_Check under
Apache License, Version 2.0.
- "Simian (Similarity Analyser) identifies duplication in Java, C#, C, CPP,
- COBOL, Ruby, JSP, ASP, HTML, XML, Visual Basic, Groovy source code and even
- plain text files." It is available at https://www.harukizaemon.com/simian/
- and is for free use in open source projects.
-
"The Nu Html Checker (v.Nu) is the backend of checker.html5.org,
html5.validator.nu, and validator.w3.org/nu." It is available at
https://validator.github.io/validator/ under MIT license.
@@ -114,20 +109,6 @@
value="${rat.report.dir}/report.html"
description="Name of Apache Rat report"/>
- <!-- Simian -->
- <property name="simian.version"
- value="2.5.10"
- description="Which version of Simian to use"/>
- <property name="simian.uri"
-
value="http://www.harukizaemon.com/simian/simian-${simian.version}.tar.gz";
- description="Where to get Simian"/>
- <property name="simian.lib.dir"
- value="${build.dir}/simian-lib"
- description="Where to store Simian resources"/>
- <property name="simian.report.dir"
- value="${reports.dir}/simian"
- description="Where to store Simian reports"/>
-
<!-- OWASP Dependency Check -->
<property name="owasp.dc.version"
value="3.2.1"
@@ -223,37 +204,6 @@
</concat>
</target>
- <target name="simiancheck" description="--> runs the check for duplicates">
- <available property="simian.jar.present"
file="${simian.lib.dir}/simian-${simian.version}.jar"/>
- <sequential unless:set="simian.jar.present">
- <echo>Install Simian ${simian.version}</echo>
- <mkdir dir="${simian.lib.dir}"/>
- <get src="${simian.uri}" dest="${simian.lib.dir}"/>
- <gunzip src="${simian.lib.dir}/simian-${simian.version}.tar.gz"
dest="${simian.lib.dir}/simian-${simian.version}.tar"/>
- <untar src="${simian.lib.dir}/simian-${simian.version}.tar"
dest="${simian.lib.dir}">
- <patternset>
- <include name="**/simian*.jar"/>
- <include name="**/simian*.xsl"/>
- </patternset>
- <flattenmapper/>
- </untar>
- </sequential>
-
- <echo>Run Simian</echo>
- <taskdef resource="simiantask.properties">
- <classpath>
- <fileset dir="${simian.lib.dir}" includes="*.jar"/>
- </classpath>
- </taskdef>
- <mkdir dir="${simian.report.dir}"/>
- <simian failureProperty="simian.duplicates.found">
- <fileset dir="${java.dir}"/>
- <formatter type="plain" toFile="${simian.report.dir}/simian-log.txt"/>
- <formatter type="xml" toFile="${simian.report.dir}/simian-log.xml"/>
- </simian>
- <xslt in="${simian.report.dir}/simian-log.xml"
style="${simian.lib.dir}/simian.xsl" out="${simian.report.dir}/simian.html"/>
- </target>
-
<target name="fixTS" description="--> fix checkstyle errors 'Line has
trailing spaces'">
<fail message="Define path to java file 'path'">
<condition><not><isset property="path"/></not></condition>
diff --git a/src/etc/checkstyle/checkstyle-config
b/src/etc/checkstyle/checkstyle-config
index f0b46c56f..8e2dde32b 100644
--- a/src/etc/checkstyle/checkstyle-config
+++ b/src/etc/checkstyle/checkstyle-config
@@ -129,7 +129,6 @@
<property name="format" value="\s+$"/>
</module>
- <!-- <module name="au.com.redhillconsulting.simian.SimianCheck"/> -->
<module name="SuppressionCommentFilter">
<property name="offCommentFormat" value="CheckStyle\:([\w\|]+) *OFF"/>
<property name="onCommentFormat" value="CheckStyle\:([\w\|]+) *ON"/>
