moonming commented on a change in pull request #855: Allow APISIX config more Nginx-built-in directives into nginx.conf URL: https://github.com/apache/incubator-apisix/pull/855#discussion_r346164730
########## File path: conf/config.yaml ########## @@ -65,6 +65,11 @@ nginx_config: # config for render the template to genarate n client_header_timeout: 60s # timeout for reading client request header, then 408 (Request Time-out) error is returned to the client client_body_timeout: 60s # timeout for reading client request body, then 408 (Request Time-out) error is returned to the client send_timeout: 10s # timeout for transmitting a response to the client.then the connection is closed + server: # set custusmized directives in nginx.conf server field + server_tokens: on # Enables emitting nginx version on error pages and in the "Server" Review comment: `server_tokens` is off in `http`, why set to `on` here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services