membphis commented on a change in pull request #976: Added password support for plugin limit-count-redis URL: https://github.com/apache/incubator-apisix/pull/976#discussion_r361117337
########## File path: lua/apisix/plugins/limit-count/limit-count-redis.lua ########## @@ -51,6 +51,13 @@ function _M.incoming(self, key) return false, err end + if conf.redis_password and conf.redis_password ~= '' then Review comment: we need to check if this sock was used for first time by API: https://github.com/openresty/lua-nginx-module#tcpsockgetreusedtimes Call the `auth` if the `reusedtimes` equal 0. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services