membphis commented on a change in pull request #1051: feature: upstream support websocket enable URL: https://github.com/apache/incubator-apisix/pull/1051#discussion_r366138129
########## File path: lua/apisix/schema_def.lua ########## @@ -273,6 +273,11 @@ local upstream_schema = { description = "the key of chash for dynamic load balancing", type = "string", }, + enable_websocket = { + description = "enable websocket for request", + type = "boolean", + default = false Review comment: we can delete this `default`, we can use `nil` as `false` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services