Miss-you edited a comment on issue #1096: add cors plugin URL: https://github.com/apache/incubator-apisix/pull/1096#issuecomment-581390467 A brief look at the code: 1. Need process the "Preflight Request." which is an "OPTIONS" request. It seems only supporting the simple requests. 2. Need test case. 3. The default value of the max_age suggestion is 24 hours, 86400. 4. Headers and other arrays need to use the string directly. Otherwise, each request needs to concatenate several tables into strings, which is obviously costly.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
