membphis commented on a change in pull request #1153: feature: support for 
proxy caching plugin based on disk.
URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r385680075
 
 

 ##########
 File path: conf/config.yaml
 ##########
 @@ -35,6 +35,19 @@ apisix:
   #  enable_tcp_pp: true           # Enable the proxy protocol for tcp proxy, 
it works for stream_proxy.tcp option
   #  enable_tcp_pp_to_upstream: true # Enables the proxy protocol to the 
upstream server
 
+  #proxy_cache:                     # Proxy Caching configuration
+  #  cache_ttl: 10s                 # The default caching time if the upstream 
does not specify the cache time
+  #   zone:                          # The parameters of a cache
+  #  - name: disk_cache_one         # The name of the cache, administrator can 
be specify
 
 Review comment:
   bad indentation
   
   ```yaml
     # proxy_cache:                            # Proxy Caching configuration
     #   cache_ttl: 1m                         # The default caching time if 
the upstream does not specify the cache time
     #   zones:                                # The parameters of a cache
     #     - name: disk_cache_one              # The name of the cache, 
administrator can be specify
     #                                         # which cache to use by name in 
the admin api
     #       memory_size: 50m                  # The size of shared memory, 
it's used to store the cache index
     #       disk_size: 1G                     # The size of disk, it's used to 
store the cache data
     #       disk_path: "/tmp/disk_cache_one"  # The path to store the cache 
data
     #     - name: disk_cache_two
     #       memory_size: 50m
     #       disk_size: 1G
     #       disk_path: "/tmp/disk_cache_two"
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to