agile6v commented on a change in pull request #1153: feature: support for proxy
caching plugin based on disk.
URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r386113243
##########
File path: bin/apisix
##########
@@ -410,6 +410,7 @@ http {
set $upstream_hdr_cache_control '';
proxy_cache $upstream_cache_zone;
+ proxy_cache_valid 502 504 0s;
Review comment:
Yes. here will be confusing. If 502 returned from upstream, the
proxy_no_cache directive will take effect. But it returned from APISIX, the
proxy_no_cache directive will not take effect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
