moonming commented on a change in pull request #1167: feature: auto import
nameservers into APISIX from system resolv file.…
URL: https://github.com/apache/incubator-apisix/pull/1167#discussion_r388035303
##########
File path: bin/apisix
##########
@@ -603,6 +631,18 @@ local function init()
sys_conf["worker_processes"] = "auto"
end
+ local dns_addrs = system_dns_resolver()
+ if dns_addrs then
Review comment:
I think this logic is not right. If `bin / apisix` fails to read
/etc/resolv.conf, then the `dns_resolver` configured in `config.yaml` will also
fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
