Akayeshmantha commented on a change in pull request #1312: Kafka Logger.
URL: https://github.com/apache/incubator-apisix/pull/1312#discussion_r396364390
 
 

 ##########
 File path: .travis/osx_openresty_runner.sh
 ##########
 @@ -33,6 +33,26 @@ before_install() {
     sudo cpanm --notest Test::Nginx >build.log 2>&1 || (cat build.log && exit 
1)
     export_or_prefix
     luarocks install --lua-dir=${OPENRESTY_PREFIX}/luajit luacov-coveralls 
--local --tree=deps
+
+    # spin up kafka cluster for tests (1 zookeper and 1 kafka instance)
 
 Review comment:
   oh okays. I didnt know that

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to