spacewander commented on code in PR #7630:
URL: https://github.com/apache/apisix/pull/7630#discussion_r942044257
##########
apisix/core/config_etcd.lua:
##########
@@ -212,14 +212,15 @@ local function load_full_data(self, dir_res, headers)
self:upgrade_version(item.modifiedIndex)
else
- if not dir_res.nodes then
- dir_res.nodes = {}
+ local values = (dir_res and dir_res.nodes) or dir_res
Review Comment:
Is `or dir_res` useful?
If dir_res is nil, we don't need `or dir_res`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
