guoqqqi commented on code in PR #2641:
URL: https://github.com/apache/apisix-dashboard/pull/2641#discussion_r1001267993
##########
web/cypress/e2e/rest/pluginTemplate-create-edit-delete-plugin-template.cy.js:
##########
@@ -48,7 +48,9 @@ context('Create Configure and Delete PluginTemplate', () => {
cy.visit('/');
cy.contains('Route').click();
cy.get(selector.empty).should('be.visible');
- cy.contains('Advanced').should('be.visible').click();
+ cy.contains('Advanced').trigger('mouseover');
+ cy.wait(50);
Review Comment:
We should avoid abusing wait, and use some should assertions to ensure that
the tests are stable.
##########
web/cypress/e2e/rest/pluginTemplate-create-plugin-template-with-route.cy.js:
##########
@@ -56,7 +56,9 @@ context('Create PluginTemplate Binding To Route', () => {
cy.visit('/');
cy.contains('Route').click();
cy.get(selector.empty).should('be.visible');
- cy.contains('Advanced').should('be.visible').click();
+ cy.contains('Advanced').trigger('mouseover');
+ cy.wait(50);
Review Comment:
ditto
##########
web/cypress/e2e/rest/upstream-create_and_edit_upstream_with_no_nodes.cy.js:
##########
@@ -61,9 +61,8 @@ context('Create and Delete Upstream', () => {
cy.get(selector.nameSelector).type(data.upstreamName);
cy.contains('Search').click();
cy.contains(data.upstreamName).siblings().contains('Configure').click();
-
cy.get(selector.upstreamNodeMinus0).should('not.exist');
- cy.contains('button', 'Next').should('not.be.disabled').click();
+ cy.contains('button', 'Next').should('not.be.disabled').wait(10).click();
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
