spacewander commented on code in PR #8206:
URL: https://github.com/apache/apisix/pull/8206#discussion_r1014819332
##########
apisix/plugins/jwt-auth.lua:
##########
@@ -200,15 +209,28 @@ local function fetch_jwt_token(conf, ctx)
return token
end
- token = ctx.var["arg_" .. conf.query]
+ local uri_args = core.request.get_uri_args(ctx) or {}
+ token = uri_args[conf.query]
if token then
+ if conf.hide_credentials then
+ -- hide for query
+ uri_args[conf.query] = nil
+ core.request.set_uri_args(ctx, uri_args)
+ end
return token
end
local val = ctx.var["cookie_" .. conf.cookie]
if not val then
return nil, "JWT not found in cookie"
end
+
+ if conf.hide_credentials then
+ -- hide for cookie
+ local reset_val = conf.cookie .. "=deleted; Max-Age=0"
Review Comment:
The Max-Age attribute is for Set-Cookie. What about parsing the Cookie
header and removing the relative field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
