moonming commented on a change in pull request #2092:
URL: https://github.com/apache/apisix/pull/2092#discussion_r479999769
##########
File path: .travis/linux_apisix_master_luarocks_runner.sh
##########
@@ -63,6 +63,14 @@ script() {
sudo mkdir -p /usr/local/apisix/deps
sudo PATH=$PATH ./utils/install-apisix.sh install > build.log 2>&1 || (cat
build.log && exit 1)
+ cat > /usr/local/apisix/conf/config.yaml <<EOF
+apisix:
+ admin_key:
+ -
+ name: "admin"
+ key: YOUR_API_KEY
Review comment:
ditto
##########
File path: .travis/linux_openresty_mtls_runner.sh
##########
@@ -103,6 +103,11 @@ script() {
apisix:
port_admin: 9180
https_admin: true
+ admin_key:
+ -
+ name: "admin"
+ key: MTLS_API_KEY
Review comment:
ditto
##########
File path: conf/config-default.yaml
##########
@@ -69,16 +69,16 @@ apisix:
# *NOTE*: Highly recommended to modify this value to protect APISIX's Admin
API.
# Disabling this configuration item means that the Admin API does not
# require any authentication.
- admin_key:
- -
- name: "admin"
- key: edd1c9f034335f136f87ad84b625c8f1
- role: admin # admin: manage all configuration data
- # viewer: only can view configuration data
- -
- name: "viewer"
- key: 4054f7cf07e344346cd3f287985e76a2
- role: viewer
+ # admin_key:
+ # -
+ # name: "admin"
+ # key: YOUR_ADMIN_API_KEY
Review comment:
repeat
https://github.com/apache/apisix/pull/2092/files#diff-82e3bcd74a1f6e15d0577acef2d4fa8cR25-R33?
##########
File path: .travis/linux_apisix_current_luarocks_runner.sh
##########
@@ -62,6 +62,15 @@ script() {
# show install file
luarocks show apisix
+ cat > /usr/local/apisix/conf/config.yaml <<EOF
+apisix:
+ admin_key:
+ -
+ name: "admin"
+ key: YOUR_API_KEY
Review comment:
how about make random key as
https://github.com/apache/apisix/pull/2092/files#diff-6e12d95c1b302dbedef4dd82dbee073cR26?
##########
File path: t/lib/test_admin.lua
##########
@@ -128,6 +128,7 @@ function _M.test(uri, method, body, pattern, headers)
end
if not headers["Content-Type"] then
headers["Content-Type"] = "application/x-www-form-urlencoded"
+ headers["X-API-KEY"] = "TEST_API_KEY"
Review comment:
random key or hard code key, not using `TEST_API_KEY` as key
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
