spacewander commented on code in PR #8557:
URL: https://github.com/apache/apisix/pull/8557#discussion_r1056083134
##########
apisix/plugins/grpc-transcode/proto.lua:
##########
@@ -270,5 +270,10 @@ function _M.init()
end
end
+function _M.destroy()
+ if protos then
+ protos:close()
Review Comment:
Could we add a test to ensure the `close` is called? For instance, via
injecting some code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
