spacewander commented on a change in pull request #2163:
URL: https://github.com/apache/apisix/pull/2163#discussion_r484460351



##########
File path: apisix/http/router/radixtree_sni.lua
##########
@@ -95,6 +134,9 @@ local function create_router(ssl_items)
         end
     end
 
+    parsed_certs = core.table.new(0, idx)
+    parsed_pkeys = core.table.new(0, idx)

Review comment:
       Maybe we can store the parsed data in `ssl.value` directly, so the data 
can be reused even after router recreated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to