ronething commented on code in PR #8640:
URL: https://github.com/apache/apisix/pull/8640#discussion_r1067796292
##########
ci/linux_openresty_1_19_runner.sh:
##########
@@ -17,5 +17,5 @@
#
-export OPENRESTY_VERSION=1.19.3.2
+export OPENRESTY_VERSION=1.19.9.1
Review Comment:
@spacewander
- first, it will cause err like below when start apisix with openresty
1.19.3.2, because `local discovery =
require("apisix.discovery.init").discovery` in `apisix/upstream.lua:19` will
import `discovery/kubernetes/init.lua`.
```
$ ./bin/apisix start
/usr/local/openresty-debug//luajit/bin/luajit ./apisix/cli/apisix.lua start
nginx: [error] init_by_lua error:
/usr/local/openresty-debug/lualib/ngx/process.lua:5: unsupported subsystem:
stream
stack traceback:
[C]: in function 'error'
/usr/local/openresty-debug/lualib/resty/core/base.lua:223: in
function 'allows_subsystem'
/usr/local/openresty-debug/lualib/ngx/process.lua:5: in main chunk
[C]: in function 'require'
...ng/Documents/apisix/apisix/discovery/kubernetes/init.lua:29: in
main chunk
[C]: in function 'require'
/home/ronething/Documents/apisix/apisix/discovery/init.lua:28: in
main chunk
[C]: in function 'require'
/home/ronething/Documents/apisix/apisix/upstream.lua:19: in main
chunk
[C]: in function 'require'
/home/ronething/Documents/apisix/apisix/http/service.lua:18: in main
chunk
[C]: in function 'require'
/home/ronething/Documents/apisix/apisix/init.lua:35: in main chunk
[C]: in function 'require'
init_by_lua:3: in main chunk
```
- then, something like `if conf.pass_host == "node" and conf.nodes and ` in
`check_upstream_conf` function may only print error log when check upstream if
`in_dp` is true, or cause err when post/put upstream or other resource which
need to check upstream_conf both in http and stream subsystem. But we need to
refuse to start apisix when the OpenResty is too old and k8s discovery is used
in the stream?
so maybe we should consider other solutions? if something i was wrong,
please tell me, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
