spacewander commented on a change in pull request #2174:
URL: https://github.com/apache/apisix/pull/2174#discussion_r486286638
##########
File path: conf/config-default.yaml
##########
@@ -115,6 +115,8 @@ nginx_config: # config for render the
template to genarate n
worker_shutdown_timeout: 240s # timeout for a graceful shutdown of
worker processes
event:
worker_connections: 10620
+ envs:
+ - APISIX_PROFILE
Review comment:
Since default configure can be overridden by the user, I think we should
always include `APISIX_PROFILE` in the nginx.conf template. Otherwise,
`APISIX_PROFILE` might be lost by mistake. We can leave a comment here as
example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
