sakulali commented on code in PR #1666:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1666#discussion_r1122014446
##########
Makefile:
##########
@@ -222,9 +222,19 @@ verify-license:
verify-mdlint:
docker run -it --rm -v $(PWD):/work tmknom/markdownlint '**/*.md'
--ignore node_modules --ignore CHANGELOG.md
+### verify-yamllint: Verify yaml files lint rules for `samples/deploy`
directory.
+.PHONY: verify-yamllint
+verify-yamllint:
+ docker run -it --rm -v $(PWD):/yaml peterdavehello/yamllint yamllint
samples/deploy
+
### verify-all: Verify all verify- rules.
.PHONY: verify-all
-verify-all: verify-codegen verify-license verify-mdlint
+verify-all: verify-codegen verify-license verify-mdlint verify-yamllint
+
+### update-yamlfmt: Update yaml files format for `samples/deploy`
directory.
+.PHONY: update-yamlfmt
+update-yamlfmt:
+ go install github.com/google/yamlfmt/cmd/yamlfmt@latest && yamlfmt
samples/deploy
Review Comment:
@tao12345666333 , I found `yamllint` is a linter without support formating
YAML https://github.com/adrienverge/yamllint/issues/62#issuecomment-679873297 ,
and i found another tool [https://github.com/google/yamlfmt](url) to fix the
format of YAML.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
