liuxiran commented on a change in pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r486745396
##########
File path: src/pages/Route/typing.d.ts
##########
@@ -113,6 +116,7 @@ declare namespace RouteModule {
// Request Body or Response Data for API
type Body = {
id?: number;
+ status: boolean;
Review comment:
If moved `status` to abisix, it could be a good extension as a basis for
route lifecycle management, and if not, `status` only a a new field of the
route table in the current mysql, which is not associated with other tables, it
would be easier to migrate in new manager api .
##########
File path: src/pages/Route/typing.d.ts
##########
@@ -113,6 +116,7 @@ declare namespace RouteModule {
// Request Body or Response Data for API
type Body = {
id?: number;
+ status: boolean;
Review comment:
If moved `status` to abisix, it could be a good extension as a basis for
route lifecycle management, and if not, `status` is only a new field of the
route table in the current mysql, which is not associated with other tables, it
would be easier to migrate in new manager api :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
