moonming commented on a change in pull request #2168:
URL: https://github.com/apache/apisix/pull/2168#discussion_r486902889
##########
File path: apisix/core/config_etcd.lua
##########
@@ -314,36 +316,44 @@ local function sync_data(self)
res.value.id = key
self.values[pre_index] = res
res.clean_handlers = {}
+ log.info("update data by key: ", key)
else
self.sync_times = self.sync_times + 1
self.values[pre_index] = false
+ self.values_hash[key] = nil
+ log.info("delete data by key: ", key)
end
elseif res.value then
res.clean_handlers = {}
insert_tab(self.values, res)
self.values_hash[key] = #self.values
res.value.id = key
+ log.info("insert data by key: ", key)
end
-- avoid space waste
-- todo: need to cover this path, it is important.
if self.sync_times > 100 then
- local count = 0
- for i = 1, #self.values do
- local val = self.values[i]
- self.values[i] = nil
+ local values_org = table.clone(self.values)
Review comment:
`org` means organization
##########
File path: apisix/core/config_etcd.lua
##########
@@ -314,36 +316,44 @@ local function sync_data(self)
res.value.id = key
self.values[pre_index] = res
res.clean_handlers = {}
+ log.info("update data by key: ", key)
else
self.sync_times = self.sync_times + 1
self.values[pre_index] = false
+ self.values_hash[key] = nil
+ log.info("delete data by key: ", key)
end
elseif res.value then
res.clean_handlers = {}
insert_tab(self.values, res)
self.values_hash[key] = #self.values
res.value.id = key
+ log.info("insert data by key: ", key)
end
-- avoid space waste
-- todo: need to cover this path, it is important.
if self.sync_times > 100 then
- local count = 0
- for i = 1, #self.values do
- local val = self.values[i]
- self.values[i] = nil
+ local values_org = table.clone(self.values)
Review comment:
so `values_original`
##########
File path: apisix/core/config_etcd.lua
##########
@@ -314,36 +316,44 @@ local function sync_data(self)
res.value.id = key
self.values[pre_index] = res
res.clean_handlers = {}
+ log.info("update data by key: ", key)
else
self.sync_times = self.sync_times + 1
self.values[pre_index] = false
+ self.values_hash[key] = nil
+ log.info("delete data by key: ", key)
end
elseif res.value then
res.clean_handlers = {}
insert_tab(self.values, res)
self.values_hash[key] = #self.values
res.value.id = key
+ log.info("insert data by key: ", key)
end
-- avoid space waste
-- todo: need to cover this path, it is important.
if self.sync_times > 100 then
- local count = 0
- for i = 1, #self.values do
- local val = self.values[i]
- self.values[i] = nil
+ local values_org = table.clone(self.values)
Review comment:
`org` means organization
##########
File path: apisix/core/config_etcd.lua
##########
@@ -314,36 +316,44 @@ local function sync_data(self)
res.value.id = key
self.values[pre_index] = res
res.clean_handlers = {}
+ log.info("update data by key: ", key)
else
self.sync_times = self.sync_times + 1
self.values[pre_index] = false
+ self.values_hash[key] = nil
+ log.info("delete data by key: ", key)
end
elseif res.value then
res.clean_handlers = {}
insert_tab(self.values, res)
self.values_hash[key] = #self.values
res.value.id = key
+ log.info("insert data by key: ", key)
end
-- avoid space waste
-- todo: need to cover this path, it is important.
if self.sync_times > 100 then
- local count = 0
- for i = 1, #self.values do
- local val = self.values[i]
- self.values[i] = nil
+ local values_org = table.clone(self.values)
Review comment:
so `values_original`
##########
File path: apisix/core/config_etcd.lua
##########
@@ -314,36 +316,44 @@ local function sync_data(self)
res.value.id = key
self.values[pre_index] = res
res.clean_handlers = {}
+ log.info("update data by key: ", key)
else
self.sync_times = self.sync_times + 1
self.values[pre_index] = false
+ self.values_hash[key] = nil
+ log.info("delete data by key: ", key)
end
elseif res.value then
res.clean_handlers = {}
insert_tab(self.values, res)
self.values_hash[key] = #self.values
res.value.id = key
+ log.info("insert data by key: ", key)
end
-- avoid space waste
-- todo: need to cover this path, it is important.
if self.sync_times > 100 then
- local count = 0
- for i = 1, #self.values do
- local val = self.values[i]
- self.values[i] = nil
+ local values_org = table.clone(self.values)
Review comment:
`org` means organization
##########
File path: apisix/core/config_etcd.lua
##########
@@ -314,36 +316,44 @@ local function sync_data(self)
res.value.id = key
self.values[pre_index] = res
res.clean_handlers = {}
+ log.info("update data by key: ", key)
else
self.sync_times = self.sync_times + 1
self.values[pre_index] = false
+ self.values_hash[key] = nil
+ log.info("delete data by key: ", key)
end
elseif res.value then
res.clean_handlers = {}
insert_tab(self.values, res)
self.values_hash[key] = #self.values
res.value.id = key
+ log.info("insert data by key: ", key)
end
-- avoid space waste
-- todo: need to cover this path, it is important.
if self.sync_times > 100 then
- local count = 0
- for i = 1, #self.values do
- local val = self.values[i]
- self.values[i] = nil
+ local values_org = table.clone(self.values)
Review comment:
so `values_original`
##########
File path: apisix/core/config_etcd.lua
##########
@@ -314,36 +316,44 @@ local function sync_data(self)
res.value.id = key
self.values[pre_index] = res
res.clean_handlers = {}
+ log.info("update data by key: ", key)
else
self.sync_times = self.sync_times + 1
self.values[pre_index] = false
+ self.values_hash[key] = nil
+ log.info("delete data by key: ", key)
end
elseif res.value then
res.clean_handlers = {}
insert_tab(self.values, res)
self.values_hash[key] = #self.values
res.value.id = key
+ log.info("insert data by key: ", key)
end
-- avoid space waste
-- todo: need to cover this path, it is important.
if self.sync_times > 100 then
- local count = 0
- for i = 1, #self.values do
- local val = self.values[i]
- self.values[i] = nil
+ local values_org = table.clone(self.values)
Review comment:
`org` means organization
##########
File path: apisix/core/config_etcd.lua
##########
@@ -314,36 +316,44 @@ local function sync_data(self)
res.value.id = key
self.values[pre_index] = res
res.clean_handlers = {}
+ log.info("update data by key: ", key)
else
self.sync_times = self.sync_times + 1
self.values[pre_index] = false
+ self.values_hash[key] = nil
+ log.info("delete data by key: ", key)
end
elseif res.value then
res.clean_handlers = {}
insert_tab(self.values, res)
self.values_hash[key] = #self.values
res.value.id = key
+ log.info("insert data by key: ", key)
end
-- avoid space waste
-- todo: need to cover this path, it is important.
if self.sync_times > 100 then
- local count = 0
- for i = 1, #self.values do
- local val = self.values[i]
- self.values[i] = nil
+ local values_org = table.clone(self.values)
Review comment:
so `values_original`
##########
File path: apisix/core/config_etcd.lua
##########
@@ -314,36 +316,44 @@ local function sync_data(self)
res.value.id = key
self.values[pre_index] = res
res.clean_handlers = {}
+ log.info("update data by key: ", key)
else
self.sync_times = self.sync_times + 1
self.values[pre_index] = false
+ self.values_hash[key] = nil
+ log.info("delete data by key: ", key)
end
elseif res.value then
res.clean_handlers = {}
insert_tab(self.values, res)
self.values_hash[key] = #self.values
res.value.id = key
+ log.info("insert data by key: ", key)
end
-- avoid space waste
-- todo: need to cover this path, it is important.
if self.sync_times > 100 then
- local count = 0
- for i = 1, #self.values do
- local val = self.values[i]
- self.values[i] = nil
+ local values_org = table.clone(self.values)
Review comment:
`org` means organization
##########
File path: apisix/core/config_etcd.lua
##########
@@ -314,36 +316,44 @@ local function sync_data(self)
res.value.id = key
self.values[pre_index] = res
res.clean_handlers = {}
+ log.info("update data by key: ", key)
else
self.sync_times = self.sync_times + 1
self.values[pre_index] = false
+ self.values_hash[key] = nil
+ log.info("delete data by key: ", key)
end
elseif res.value then
res.clean_handlers = {}
insert_tab(self.values, res)
self.values_hash[key] = #self.values
res.value.id = key
+ log.info("insert data by key: ", key)
end
-- avoid space waste
-- todo: need to cover this path, it is important.
if self.sync_times > 100 then
- local count = 0
- for i = 1, #self.values do
- local val = self.values[i]
- self.values[i] = nil
+ local values_org = table.clone(self.values)
Review comment:
so `values_original`
##########
File path: apisix/core/config_etcd.lua
##########
@@ -314,36 +316,44 @@ local function sync_data(self)
res.value.id = key
self.values[pre_index] = res
res.clean_handlers = {}
+ log.info("update data by key: ", key)
else
self.sync_times = self.sync_times + 1
self.values[pre_index] = false
+ self.values_hash[key] = nil
+ log.info("delete data by key: ", key)
end
elseif res.value then
res.clean_handlers = {}
insert_tab(self.values, res)
self.values_hash[key] = #self.values
res.value.id = key
+ log.info("insert data by key: ", key)
end
-- avoid space waste
-- todo: need to cover this path, it is important.
if self.sync_times > 100 then
- local count = 0
- for i = 1, #self.values do
- local val = self.values[i]
- self.values[i] = nil
+ local values_org = table.clone(self.values)
Review comment:
`org` means organization
##########
File path: apisix/core/config_etcd.lua
##########
@@ -314,36 +316,44 @@ local function sync_data(self)
res.value.id = key
self.values[pre_index] = res
res.clean_handlers = {}
+ log.info("update data by key: ", key)
else
self.sync_times = self.sync_times + 1
self.values[pre_index] = false
+ self.values_hash[key] = nil
+ log.info("delete data by key: ", key)
end
elseif res.value then
res.clean_handlers = {}
insert_tab(self.values, res)
self.values_hash[key] = #self.values
res.value.id = key
+ log.info("insert data by key: ", key)
end
-- avoid space waste
-- todo: need to cover this path, it is important.
if self.sync_times > 100 then
- local count = 0
- for i = 1, #self.values do
- local val = self.values[i]
- self.values[i] = nil
+ local values_org = table.clone(self.values)
Review comment:
so `values_original`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
