monkeyDluffy6017 commented on code in PR #9247:
URL: https://github.com/apache/apisix/pull/9247#discussion_r1159912182
##########
apisix/ssl.lua:
##########
@@ -252,9 +253,14 @@ function _M.check_ssl_conf(in_dp, conf)
end
end
- local ok, err = validate(conf.cert, conf.key)
- if not ok then
- return nil, err
+ -- if the certificate uses a secret reference, we only verify it when
using it
+ if not secret.check_secret_uri(conf.cert) and
+ not secret.check_secret_uri(conf.key) then
+
Review Comment:
what about only one use a secret? should we check this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
