Chever-John commented on code in PR #1460:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/1460#discussion_r1160626545


##########
Makefile:
##########
@@ -325,3 +324,19 @@ install-gateway-api-local:
 .PHONY: uninstall-gateway-api
 uninstall-gateway-api:
        kubectl delete -f $(GATEWAY_API_CRDS_LOCAL_PATH)
+
+### dev-env:                     Launch development environment
+.PHONY: dev-env
+dev-env: kind-up pack-image
+       helm repo add apisix https://charts.apiseven.com
+       helm repo update
+       helm install apisix apisix/apisix \
+               --set gateway.type=NodePort \
+               --set ingress-controller.enabled=true \
+               --namespace ingress-apisix \
+               --create-namespace
+       kubectl set image deployment/apisix-ingress-controller 
ingress-controller=$(REGISTRY)/apache/apisix-ingress-controller:dev --namespace 
ingress-apisix
+

Review Comment:
   Hi, can u try this?
   
   ```makefile
   ### dev-env:                   Launch development environment
   .PHONY: dev-env
   dev-env: kind-up pack-image
        -helm repo add apisix https://charts.apiseven.com 2>&1 | grep -q 
"Error: repository name (apisix) already exists" && echo "Apisix already 
exists, skipping installation" || \
                (helm repo update && \
                 helm list -n ingress-apisix | grep -q apisix && echo "Apisix 
already exists, skipping installation" || \
                 helm install apisix apisix/apisix \
                        --set gateway.type=NodePort \
                        --set ingress-controller.enabled=true \
                        --namespace ingress-apisix \
                        --create-namespace && \
                 kubectl set image deployment/apisix-ingress-controller 
ingress-controller=$(REGISTRY)/apache/apisix-ingress-controller:dev --namespace 
ingress-apisix)
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to