monkeyDluffy6017 commented on code in PR #9247:
URL: https://github.com/apache/apisix/pull/9247#discussion_r1163464979
##########
apisix/ssl.lua:
##########
@@ -252,9 +253,14 @@ function _M.check_ssl_conf(in_dp, conf)
end
end
- local ok, err = validate(conf.cert, conf.key)
- if not ok then
- return nil, err
+ -- when cert or key is referenced by secret, avoid dynamic verification of
it
Review Comment:
check like this, it can be cached in advance and verified:
```
local new_ssl_value = secret.fetch_secrets(matched_ssl.value) or
matched_ssl.value
local ok, err = validate(new_ssl_value.cert, new_ssl_value.key )
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
