kingluo commented on code in PR #9194:
URL: https://github.com/apache/apisix/pull/9194#discussion_r1165346463
##########
docs/en/latest/plugins/proxy-rewrite.md:
##########
@@ -38,7 +38,8 @@ The `proxy-rewrite` Plugin rewrites Upstream proxy
information such as `scheme`,
|-----------------------------|---------------|----------|---------|----------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| uri | string | False | |
| New Upstream forwarding address.
Value supports [Nginx
variables](https://nginx.org/en/docs/http/ngx_http_core_module.html). For
example, `$arg_name`.
|
| method | string | False | | ["GET",
"POST", "PUT", "HEAD", "DELETE", "OPTIONS","MKCOL", "COPY", "MOVE", "PROPFIND",
"PROPFIND","LOCK", "UNLOCK", "PATCH", "TRACE"] | Rewrites the HTTP method.
|
-| regex_uri | array[string] | False | |
| New upstream forwarding address.
Regular expressions can be used to match the URL from client. If it matches,
the URL template is forwarded to the Upstream otherwise, the URL from the
client is forwarded. When both `uri` and `regex_uri` are configured, `uri` is
used first. For example, `[" ^/iresty/(.*)/(.*)/(.*)", "/$1-$2-$3"]`. Here, the
first element is the regular expression to match and the second element is the
URL template forwarded to the Upstream. |
+| none_match_abort | boolean | False |
`false` | | Abort with 404 status code when none of regex_uri matched,
useful when making only those routes that match regular expression patterns
public.
|
+| regex_uri | array[string] | False | |
| New upstream forwarding address.
Regular expressions can be used to match the URL from client. If it matches,
the URL template is forwarded to the Upstream otherwise, the URL from the
client is forwarded if `none_match_abort=false`. When both `uri` and
`regex_uri` are configured, `uri` is used first. For example,
`["^/iresty/(.*)/(.*)/(.*)", "/$1-$2-$3", ^/theothers/(.*)/(.*)",
"/theothers/$1-$2"]`. Here, the first and the third elements are the regular
expressions to match, the second and the fourth elements are the URL templates
forwarded to the Upstream. Length of this property must be a even number. |
Review Comment:
It's better to declare it supports multiple patterns for matching and
substitution. It will iterate all patterns one by one until a successful match
and substitution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
