kayx23 commented on PR #9367: URL: https://github.com/apache/apisix/pull/9367#issuecomment-1521086638
@navendu-pottekkat sigh, my favourite thing to do, adding trailing spaces and failing CI checks! Should be good now. btw, I've noticed quite a few times that people are merging doc improvements PR into version specific branches which aren't carried over the main branch. This was resulted from directing using the "edit this page" button on the front end which automatically propose PR changes into a specific version (though you can select which branch to merge into but people dont usually notice). For my first doc PR I had to open a new PR to merge into the master branch. I subsequently discovered if you JUST merge the doc change into the master branch, the change isn't reflected in the most current version of doc (say 3.2). This _might_ result in people thinking the latest doc is still outdated and waste time fixing docs that are already fixed? Wonder what the suggested practice/workflow is here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
