tokers commented on pull request #2233:
URL: https://github.com/apache/apisix/pull/2233#issuecomment-693134034
@moonming I found PR #2036 also checked the etcd version, but IMHO the way
is wrong.
Firstly, when we ask the version message from etcd, it returns a JSON string
like this:
```json
{"etcdserver":"3.5.0-pre","etcdcluster":"3.5.0"}
```
we should check the version of `etcdcluster`, not the endpoint's server
version (`etcdserver`) that we requested, the cluster version is the minimal
server version of all endpoints in the cluster. So that's the one we need to
check.
Secondly, the semantic version check method doesn't consider the `pre
release` situation, although it's rare in prod, i think's better to consider it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
