[GitHub] [apisix-dashboard] moonming commented on pull request #479: fix: host should not be required

[GitBox]

moonming commented on pull request #479:
URL: https://github.com/apache/apisix-dashboard/pull/479#issuecomment-694093851


   > create a route without host in on line demo: http://139.217.190.60/ has 
got an 500 error:
   > 
   > 
![image](https://user-images.githubusercontent.com/2561857/93443627-ed04ff80-f902-11ea-9679-e37686d5eb20.png)
   > 
   > 
![image](https://user-images.githubusercontent.com/2561857/93443930-027a2980-f903-11ea-8dde-b436d462071f.png)
   > 
   > 
![image](https://user-images.githubusercontent.com/2561857/93444090-0e65eb80-f903-11ea-93d3-ef946ed4b8e8.png)
   > 
   > 
   > 
   > Since the host is “” does not match the regular rules of apisix, when the 
host is not specified, the host in the submitData also needs to be processed to 
complete this modification 🤦‍♀️.  @LiteSun @juzhiyuan 
   > 
   > 
   > 
   > 
   
   Nice catch. @LiteSun we need add test cases for this or


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org