shreemaan-abhishek commented on code in PR #9619:
URL: https://github.com/apache/apisix/pull/9619#discussion_r1223855866
##########
t/plugin/log-rotate2.t:
##########
@@ -181,13 +181,13 @@ plugins:
- log-rotate
plugin_attr:
log-rotate:
- interval: 1
+ interval: 2
max_kept: 1
enable_compression: true
--- config
location /t {
content_by_lua_block {
- ngx.sleep(3.5)
+ ngx.sleep(2.5)
Review Comment:
why is this change needed?
##########
apisix/core/config_local.lua:
##########
@@ -55,6 +55,7 @@ end
-- local local_conf = core.config.local_conf()
-- local fallback_sni = core.table.try_read_attr(
-- local_conf, "apisix", "ssl", "fallback_sni") --
"a.test2.com"
+-- -- `nil` is returned if the attribute doesn't exist
Review Comment:
two double dashes?
##########
t/plugin/log-rotate.t:
##########
@@ -105,6 +106,7 @@ start xxxxxx
--- config
location /t {
content_by_lua_block {
+ local io = require("io")
Review Comment:
I think you will have to revert these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
