[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9619: feat: Add support for custom named log file names for log-rotate plugin

[via GitHub]

monkeyDluffy6017 commented on code in PR #9619:
URL: https://github.com/apache/apisix/pull/9619#discussion_r1230355179


##########
apisix/plugins/log-rotate.lua:
##########
@@ -72,11 +74,11 @@ local function file_exists(path)
     return file ~= nil
 end
 
-
+-- get the log directory path

Review Comment:
   need two blanks



##########
apisix/plugins/log-rotate.lua:
##########
@@ -101,15 +103,15 @@ local function get_log_path_info(file_type)
         end
     end
 
-    return prefix .. "logs/", file_type
+    return prefix , file_type
 end
 
 
 local function tab_sort_comp(a, b)
     return a > b
 end
 
-
+-- scans the log directory and returns a sorted table of matching log files

Review Comment:
   need two blanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org