jiangfucheng commented on code in PR #9843: URL: https://github.com/apache/apisix/pull/9843#discussion_r1265381857
########## apisix/plugins/tencent-cloud-cls/cls-sdk.lua: ########## @@ -62,8 +62,15 @@ local params_cache = { local function get_ip(hostname) local _, resolved = socket.dns.toip(hostname) local ip_list = {} - for _, v in ipairs(resolved.ip) do - insert_tab(ip_list, v) + if not resolved.ip then Review Comment: The original code used `socket.dns.topip`, I didn't modify it. What is the difference between these two methods? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org