[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9580: fix: Improve results from admin API while GET all plugins

[via GitHub]

monkeyDluffy6017 commented on code in PR #9580:
URL: https://github.com/apache/apisix/pull/9580#discussion_r1266106958


##########
apisix/admin/plugins.lua:
##########
@@ -42,7 +44,15 @@ end
 
 function _M.get(name)
     local arg = get_uri_args()
-    if arg and arg["all"] == "true" then
+    -- If subsystem is passed inside args then it should be oneOf: http / 
stream.
+    local subsystem = arg["subsystem"]
+    if subsystem and subsystem ~= "http" and subsystem ~= "stream" then
+        return 400, {error_msg = "unsupported subsystem: "..subsystem}
+    end

Review Comment:
   ```suggestion
       local subsystem = arg["subsystem"] or "http"
       if subsystem ~= "http" and subsystem ~= "stream" then
           return 400, {error_msg = "unsupported subsystem: "..subsystem}
       end
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org