jiangfucheng commented on code in PR #9909:
URL: https://github.com/apache/apisix/pull/9909#discussion_r1285954238
##########
apisix/core/config_etcd.lua:
##########
@@ -257,6 +260,33 @@ local function run_watch(premature)
end
+local function run_watch(premature)
+ local run_watch_th = ngx_thread_spawn(do_run_watch, premature)
+
+ ::restart::
+ local check_worker_th = ngx_thread_spawn(function ()
+ while not exiting() do
+ ngx_sleep(0.1)
+ end
+ end)
+
+ local ok, err = ngx_thread_wait(check_worker_th)
+
+ if not ok then
+ log.error("wait worker checker failed, retart checker, error: " .. err)
+ ngx_thread_kill(check_worker_th)
+ goto restart
+ end
+
+ -- waiting for do_run_watch thread to handle the final etcd event
+ ngx_sleep(1)
Review Comment:
Yes, it is not necessary. `t/node/healthcheck-stop-checker.t.` this test
case failed seems related to this, so I add the logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
