moonming commented on a change in pull request #2270: URL: https://github.com/apache/apisix/pull/2270#discussion_r493177709
########## File path: apisix/plugins/limit-req.lua ########## @@ -67,7 +67,12 @@ function _M.access(conf, ctx) return 500 end - local key = (ctx.var[conf.key] or "") .. ctx.conf_type .. ctx.conf_version + local key + if conf.key == "consumer_name" then + key = (ctx.consumer_id or "") .. ctx.conf_type .. ctx.conf_version Review comment: NO. Error handling is necessary ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org