tao12345666333 commented on code in PR #1915:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1915#discussion_r1286745603
##########
pkg/kube/apisix/apis/config/v2/types.go:
##########
@@ -773,8 +773,9 @@ type ApisixSecret struct {
// ApisixMutualTlsClientConfig describes the mutual TLS CA and verify depth
type ApisixMutualTlsClientConfig struct {
- CASecret ApisixSecret `json:"caSecret,omitempty"
yaml:"caSecret,omitempty"`
- Depth int `json:"depth,omitempty" yaml:"depth,omitempty"`
+ CASecret ApisixSecret `json:"caSecret,omitempty"
yaml:"caSecret,omitempty"`
+ Depth int `json:"depth,omitempty"
yaml:"depth,omitempty"`
+ SkipMtlsUriRegex []string `json:"skip_mtls_uri_regex,omitempty"
yaml:"skip_mtls_uri_regex, omitempty"`
Review Comment:
I think `SkipMTLSUriRegex` would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
