Revolyssup commented on PR #10086: URL: https://github.com/apache/apisix/pull/10086#issuecomment-1692966117
> Since we already have a test: > > https://github.com/apache/apisix/blob/89c1858662e34c76de01c84b665c79fcb2edaeb8/t/plugin/http-logger-log-format.t#L431-L441 > > That shows the given example function for registering vars is correct. This PR LGTM. So we should reference this test in the doc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
