wxbty commented on PR #9660: URL: https://github.com/apache/apisix/pull/9660#issuecomment-1700862540
@monkeyDluffy6017 @Sn0rt There may be some historical issues with unit testing for xrpc. In the runner class under the xrpc package, there is a loop in the run method. The session will be closed only when the protocol returns DECLINED. In this case, after sending the unary type rpc request, if you use ngx.req.socket, you will continue to listen to the next request. In the unit test, socket read timeout will appear. For example, pingpong.t, the test will report the following exception? # Failed test 't/xrpc/pingpong.t TEST 9: bad response - pattern "stream lua tcp socket connect timeout: 10" should match a line in error.log (req 0)' # at /usr/local/share/perl5/Test/Nginx/Socket.pm line 1284. # Failed test 't/xrpc/pingpong.t TEST 9: bad response - pattern "lua tcp socket send timeout: 9" should match a line in error.log (req 0)' # at /usr/local/share/perl5/Test/Nginx/Socket.pm line 1284. # Failed test 't/xrpc/pingpong.t TEST 9: bad response - pattern "stream lua tcp socket read timeout: 8" should match a line in error.log (req 0)' I don’t know why pingping.t can pass the test. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
