[GitHub] [apisix] uptree commented on a change in pull request #2305: fix: kafka-logger plugin sent to the same partition everytime

[GitBox]

uptree commented on a change in pull request #2305:
URL: https://github.com/apache/apisix/pull/2305#discussion_r494686819



##########
File path: apisix/plugins/kafka-logger.lua
##########
@@ -82,6 +84,11 @@ local function send_kafka_data(conf, log_message)
     end
 
     broker_config["request_timeout"] = conf.timeout * 1000
+    broker_config["partitioner"] = function(key, num, correlation_id)

Review comment:
       we can use "TEST 4" and "TEST 5" of kafka-logger.t test it，and number of 
partitions for a kafka topic >= 2. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org